Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46711: Allow numpy integers to be used as literals #1098

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Oct 16, 2024

Fix an issue where the new query system was rejecting numpy integers used in data IDs or bind values.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (4ff6cc6) to head (f4bac71).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   89.69%   89.70%           
=======================================
  Files         360      360           
  Lines       47394    47411   +17     
  Branches     5730     5731    +1     
=======================================
+ Hits        42512    42528   +16     
  Misses       3520     3520           
- Partials     1362     1363    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix an issue where the new query system was rejecting numpy integers used in data IDs or bind values.
@dhirving dhirving merged commit 588e17a into main Oct 17, 2024
18 checks passed
@dhirving dhirving deleted the tickets/DM-46711 branch October 17, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants