Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46259: Prevent confusing error when deriving dataId from bad exposure/detector combination #1092

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

timj
Copy link
Member

@timj timj commented Oct 5, 2024

  • Use new query system in direct butler for dimension records.
  • When querying for a detector, say, do not include the exposure in the query (if the exposure is bad the detector query will fail with a confusing error message).
  • Improve some other error messages if you have "detector=16, raft='0'" and the raft is inconsistent with the detector or the detector is not known at all.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (e212280) to head (8f1cede).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...on/lsst/daf/butler/direct_butler/_direct_butler.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   89.67%   89.68%           
=======================================
  Files         361      361           
  Lines       47306    47308    +2     
  Branches     9720     9722    +2     
=======================================
+ Hits        42424    42429    +5     
+ Misses       3504     3502    -2     
+ Partials     1378     1377    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple of minor questions.

python/lsst/daf/butler/direct_butler/_direct_butler.py Outdated Show resolved Hide resolved
python/lsst/daf/butler/direct_butler/_direct_butler.py Outdated Show resolved Hide resolved
@timj timj merged commit b419f0f into main Oct 9, 2024
17 of 18 checks passed
@timj timj deleted the tickets/DM-46259 branch October 9, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants