Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46298: Make Butler.clone public #1078

Merged
merged 2 commits into from
Sep 16, 2024
Merged

DM-46298: Make Butler.clone public #1078

merged 2 commits into from
Sep 16, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Sep 13, 2024 •
edited
Loading

Butler._clone() is now public as Butler.clone(). Unlike the original private version, it copies default values from the original instance unless they are explicitly overridden.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@dhirving
Make Butler._clone more user-friendly
57cb9c8 
Butler._clone now copies default values from the original instance unless they are explicitly overridden.
@dhirving
Make Butler._clone public as Butler.clone
91556de
@dhirving dhirving marked this pull request as ready for review September 13, 2024 18:13
@dhirving dhirving merged commit da89c37 into main Sep 16, 2024
35 checks passed
@dhirving dhirving deleted the tickets/DM-46298 branch September 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirving @TallJimbo