Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45907: Decrease page size for queries #1064

Merged
merged 1 commit into from
Aug 28, 2024
Merged

DM-45907: Decrease page size for queries #1064

merged 1 commit into from
Aug 28, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Aug 28, 2024

Decrease query driver's default page size. Queries were consuming excessive memory on Butler server, and lowering this value does not seem to make queries any slower. This reduces memory consumption for a dataset query with dimension records from ~120MB to ~30MB per in-flight query.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (11dbc91) to head (d249b51).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files         359      359           
  Lines       46473    46473           
  Branches     9558     9558           
=======================================
  Hits        41612    41612           
  Misses       3511     3511           
  Partials     1350     1350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Decrease query driver's default page size.  Queries were consuming excessive memory on Butler server, and lowering this value  does not seem to make queries any slower.  This reduces memory consumption for a dataset query with dimension records from ~120MB to ~30MB per in-flight query.
@dhirving dhirving marked this pull request as ready for review August 28, 2024 19:03
@dhirving dhirving merged commit bc1af40 into main Aug 28, 2024
18 checks passed
@dhirving dhirving deleted the tickets/DM-45907 branch August 28, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants