-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-45738: Experiments with extending butler collections API #1053
Conversation
471f3fd
to
2b7b444
Compare
still referenced by some other table, such as a dataset in a | ||
datastore (for `~CollectionType.RUN` collections only) or a | ||
`~CollectionType.CHAINED` collection of which this collection is | ||
a child. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to catch and reraise the SQLAlchemy error in order to have any chance at consistency between DirectButler
and RemoteButler
.
In fact, this seems like a good place to pull some of the CLI script logic into the Butler itself, by providing options for breaking parent relationships where necessary instead of just raising.
a5afe90
to
c140084
Compare
1ebd5e5
to
ef83e4d
Compare
Sometimes it's not missing Safir or httpx but a circular import.
Now called collections
Also sort the dataset types.
Checklist
doc/changes
configs/old_dimensions