Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45726: Pass Butler to RepoExportContext rather than Registry #1052

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

timj
Copy link
Member

@timj timj commented Aug 12, 2024

Registry is being deprecated.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (a0830e1) to head (aef9274).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   89.44%   89.44%   -0.01%     
==========================================
  Files         360      360              
  Lines       45844    45842       -2     
  Branches     9406     9406              
==========================================
- Hits        41006    41003       -3     
  Misses       3506     3506              
- Partials     1332     1333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@timj timj merged commit 20b5ab1 into main Aug 13, 2024
18 checks passed
@timj timj deleted the tickets/DM-45726 branch August 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants