DM-45556: Switch command-line tools to new query interface #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
==========================================
- Coverage 89.39% 89.37% -0.02%
==========================================
Files 360 360
Lines 45683 45750 +67
Branches 9369 9390 +21
==========================================
+ Hits 40837 40888 +51
- Misses 3520 3531 +11
- Partials 1326 1331 +5 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-45556
branch
5 times, most recently
from
a254a59
to
d479ffc
Compare
timj
commented
Aug 6, 2024
timj
force-pushed
the
tickets/DM-45556
branch
2 times, most recently
from
d83e624
to
6c9a3e4
Compare
TallJimbo
approved these changes
Aug 7, 2024
| if not refs: | ||
| raise RuntimeError(f"No inputs found for dataset {dataset_type_name} in {input_collection}.") | ||
| with butler._query() as query: | ||
| results = query.datasets(dataset_type_name, collections=input_collection) |
There was a problem hiding this comment.
The default for find-first has changed, so this is a behavior change. But I think it's an unambiguous improvement, because in the past, if the query had returned multiple results for the same data ID, the certify call later would have choked on them.
This allows it to be printed using repr()
Previously the exception that ended up with click was ExitStatus which was an empty string. This made it impossible to work out why a test failed. Now run tests in a mode where the exception is converted to ClickException which does now give feedback on test failure.
This is also needed because the pruneDatasets command line test tries to mock out the getDatasets method but doesn't try to mock out the constructor. This meant that the queryCollections code was triggering immediately but there are no collections to query. Deferring allowed the mocks to work.
It is no longer possible to use components.
The new system does not support no_check.
Otherwise they come from a set in random order each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions