DM-45386: Fix serialization of datetime64 to parquet via numpy and astropy. #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 359 359
Lines 45622 45630 +8
Branches 9348 9349 +1
=======================================
+ Hits 40775 40783 +8
Misses 3521 3521
Partials 1326 1326 ☔ View full report in Codecov by Sentry. |
erykoff
force-pushed
the
tickets/DM-45386
branch
2 times, most recently
from
ad78a93
to
6bbd594
Compare
BrunoSanchez
approved these changes
Jul 25, 2024
tests/test_parquet.py
Outdated
| @@ -138,6 +139,7 @@ def _makeSimpleNumpyTable(include_multidim=False, include_bigendian=False): | |||
| ("f", "i8"), | |||
| ("strcol", "U10"), | |||
| ("bytecol", "a10"), | |||
| ("dt", "datetime64[ns]"), | |||
There was a problem hiding this comment.
Can you add to the test the us as well? Is it relevant?
This conversion has to be done by hand, but once the correct arrow type is specified the rest of the code handles the datatype and round-trips.
The datetime column does not work correctly with the direct astropy serialization.
erykoff
force-pushed
the
tickets/DM-45386
branch
from
6bbd594
to
e246ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions