Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45317: Testing utils #1039

Closed
wants to merge 6 commits into from
Closed

DM-45317: Testing utils #1039

wants to merge 6 commits into from

Conversation

timj
Copy link
Member

@timj timj commented Jul 18, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 51.75439% with 55 lines in your changes missing coverage. Please review.

Project coverage is 34.33%. Comparing base (ce18b02) to head (bdc04b8).

Files Patch % Lines
python/lsst/daf/butler/dimensions/_coordinate.py 69.76% 10 Missing and 3 partials ⚠️
.../butler/registry/datasets/byDimensions/_storage.py 0.00% 4 Missing and 1 partial ⚠️
...daf/butler/dimensions/_data_coordinate_iterable.py 57.14% 3 Missing ⚠️
...on/lsst/daf/butler/direct_butler/_direct_butler.py 40.00% 1 Missing and 2 partials ⚠️
...hon/lsst/daf/butler/direct_query_driver/_driver.py 0.00% 3 Missing ⚠️
...thon/lsst/daf/butler/registry/dimensions/static.py 40.00% 3 Missing ⚠️
.../butler/direct_query_driver/_sql_column_visitor.py 0.00% 2 Missing ⚠️
python/lsst/daf/butler/queries/_query.py 0.00% 2 Missing ⚠️
...af/butler/registry/datasets/byDimensions/tables.py 0.00% 1 Missing and 1 partial ⚠️
python/lsst/daf/butler/registry/queries/_query.py 0.00% 2 Missing ⚠️
... and 16 more

❗ There is a different number of reports uploaded between BASE (ce18b02) and HEAD (bdc04b8). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (ce18b02) HEAD (bdc04b8)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1039       +/-   ##
===========================================
- Coverage   89.36%   34.33%   -55.03%     
===========================================
  Files         359      285       -74     
  Lines       45511    32816    -12695     
  Branches     9354     7710     -1644     
===========================================
- Hits        40673    11269    -29404     
- Misses       3536    20883    +17347     
+ Partials     1302      664      -638     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Copy link
Member Author

timj commented Jul 18, 2024

Problem is fixed in lsst/utils#185

@timj timj closed this Jul 18, 2024
@timj timj deleted the tickets/DM-45317 branch July 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants