DM-41326: remove DimensionGraph and related interfaces

[TallJimbo]

Checklist

• ran Jenkins
• added a release note for user-visible changes to doc/changes
• (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

[codecov]

Codecov Report

Attention: Patch coverage is 83.76623% with 25 lines in your changes missing coverage. Please review.

Project coverage is 89.55%. Comparing base (fd5547a) to head (73ae713).

Files	Patch %	Lines
python/lsst/daf/butler/dimensions/_coordinate.py	76.74%	7 Missing and 3 partials ⚠️
python/lsst/daf/butler/_dataset_type.py	66.66%	2 Missing and 1 partial ⚠️
...daf/butler/dimensions/_data_coordinate_iterable.py	71.42%	2 Missing ⚠️
...on/lsst/daf/butler/direct_butler/_direct_butler.py	60.00%	1 Missing and 1 partial ⚠️
python/lsst/daf/butler/dimensions/_group.py	75.00%	0 Missing and 1 partial ⚠️
python/lsst/daf/butler/dimensions/_packer.py	75.00%	1 Missing ⚠️
python/lsst/daf/butler/dimensions/_records.py	0.00%	1 Missing ⚠️
...hon/lsst/daf/butler/direct_query_driver/_driver.py	66.66%	0 Missing and 1 partial ⚠️
...ython/lsst/daf/butler/registry/obscore/_records.py	0.00%	1 Missing ⚠️
...ython/lsst/daf/butler/registry/queries/_results.py	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
+ Coverage   89.37%   89.55%   +0.18%     
==========================================
  Files         359      358       -1     
  Lines       45583    45277     -306     
  Branches     9378     9276     -102     
==========================================
- Hits        40738    40548     -190     
+ Misses       3539     3433     -106     
+ Partials     1306     1296      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timj]

Looks great. Impressive amount of cleanup work.

[timj]

Seems like match is now overkill if this is now doing:

if simple.dimensions is None:
    raise(...)
dimensions = universe.conform(simple.dimensions)

[timj]

serialized_dimensions = dimensions if dimensions else None

? Or are you worried that the type really might not be correct?

I think the type annotation for this method needs to remove the dict now.

[timj]

I see that this leads to any SerializedDatasetType JSON we have lying around being incompatible if it had the graph in it. People shouldn't have that anywhere (not even in older graphs?) but it probably means that we need to ensure the butler server deployments are updated so they don't send back the wrong form of SerializedDatasetType.

[TallJimbo]

That's right, but we've been writing this with list for a while now, so butler server should be fine, and I figured any graphs old enough to suffer from this would probably be impossible to read already due to other incompatibilities (though I don't think I can prove that in general).

[timj]

I see there is a failure:

FAILED tests/test_packages.py::PackagesFormatterTestCase::testPackages - TypeError: expected string or bytes-like object, got 'NoneType'

which is great because Fabio reported that failure this morning when building the new weekly. This means there is a chance it can be debugged more easily.