DM-43077: Convert all tasks to use CalibrateImageTask outputs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
8171aac
to
ef6b6d1
Compare
parejkoj
force-pushed
the
tickets/DM-43077
branch
from
ef6b6d1
to
2ff3535
Compare
taranu
reviewed
Oct 7, 2024
| @@ -55,14 +55,14 @@ HIPS_QGRAPH_FILE=$(mktemp)_hips.qgraph | |||
| trap 'rm -f $QGRAPH_FILE $INJECTION_QGRAPH_FILE $FARO_QGRAPH_FILE $RESOURCE_USAGE_QGRAPH_FILE \ | |||
| $HIPS_QGRAPH_FILE' EXIT | |||
|
|
|||
| # DM-46272: Change maxMeanDistanceArcsec to something smaller, so that it fails; | |||
| # even better, move those settings into DRP-ci_hsc.yaml! | |||
There was a problem hiding this comment.
I was just going to ask, is there any good reason for these not to be in DRP-ci_hsc.yaml?
| @@ -55,14 +55,14 @@ HIPS_QGRAPH_FILE=$(mktemp)_hips.qgraph | |||
| trap 'rm -f $QGRAPH_FILE $INJECTION_QGRAPH_FILE $FARO_QGRAPH_FILE $RESOURCE_USAGE_QGRAPH_FILE \ | |||
| $HIPS_QGRAPH_FILE' EXIT | |||
|
|
|||
| # DM-46272: Change maxMeanDistanceArcsec to something smaller, so that it fails; | |||
| # set. This list is sensitive to the astrometry algorithms and dataset | ||
| # under consideration, so may require updating if either of those change | ||
| # in the context of this repository. | ||
| # DM-46272: not forcing these failures until we can handle partial outputs; |
| @@ -29,48 +29,46 @@ | |||
| from lsst.utils import getPackageDir | |||
|
|
|||
|
|
|||
| # DM-46272: not forcing these failures until we can handle partial outputs; | |||
| instrument="HSC", detector=self.detector, visit=self.visit, | ||
| universe=self.butler.dimensions, | ||
| ) | ||
|
|
||
| def tearDown(self): |
There was a problem hiding this comment.
Why is this being removed? I understand that it's not really necessary to delete every primitive but deleting more heavyweight objects like self.butler seems justifiable rather than waiting for the GC to collect it whenever.
| @@ -44,14 +44,6 @@ def setUp(self): | |||
| universe=self.butler.dimensions, | |||
| ) | |||
|
|
|||
| def tearDown(self): | |||
| class TestCalibrateOutputs(lsst.utils.tests.TestCase, MockCheckMixin): | ||
| """Test the output data products of calibrate task make sense | ||
| class TestReprocessVisitImageOutputs(lsst.utils.tests.TestCase, MockCheckMixin): | ||
| """Test the output data products of reprocessVisitImage task make sense. |
TallJimbo
force-pushed
the
tickets/DM-43077
branch
from
2ff3535
to
c84a0e6
Compare
calibrateImage needs a tighter constraint here to produce a failure, and it's only in one detector/visit.
Until we've fully figured out how to handle partial outputs in DRP tasks downstream of calibrateImage, we can't use this to test failed astrometry.
TallJimbo
force-pushed
the
tickets/DM-43077
branch
from
c84a0e6
to
f2e5f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.