Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44232: Update CI pipeline to use MakeDirectWarp #112

Merged
merged 4 commits into from
Aug 15, 2024
Merged

DM-44232: Update CI pipeline to use MakeDirectWarp #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b50d45
Update CI pipeline to use MakeDirectWarp
arunkannawadi May 30, 2024
a0d11c4
Updates tests for existence of warps
arunkannawadi May 30, 2024
93e0898
Remove test_make_warp
arunkannawadi Jul 30, 2024
27da736
Take into account that directWarp may be bigger
arunkannawadi Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/pipeline.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ pipetask --long-log --log-level="$loglevel" qgraph \
-c calibrate:astrometry.maxMeanDistanceArcsec=0.025 \
-c calibrate:requireAstrometry=False \
-c calibrate:requirePhotoCal=False \
-c makeWarp:select.maxPsfTraceRadiusDelta=0.2 \
-c makeDirectWarp:select.maxPsfTraceRadiusDelta=0.2 \
--save-qgraph "$QGRAPH_FILE"

pipetask --long-log --log-level="$loglevel" run \
Expand Down
2 changes: 1 addition & 1 deletion tests/test_coadd_outputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def test_warp_inputs(self):
self.assertEqual(len(coadd_inputs.visits), 1)
visit_record = coadd_inputs.visits[0]
self.assertEqual(visit_record.getWcs(), warp.wcs)
self.assertEqual(visit_record.getBBox(), warp.getBBox())
self.assertTrue(visit_record.getBBox().contains(warp.getBBox()))
self.assertGreater(len(coadd_inputs.ccds), 0)

wcs_cat = self.butler.get(
Expand Down
11 changes: 8 additions & 3 deletions tests/test_validate_outputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,16 @@ def test_make_tables(self):
self.check_pipetasks(["makeCcdVisitTable", "makeVisitTable"], 1, 1)
self.check_datasets(["ccdVisitTable", "visitTable"], 1)

def test_make_warp(self):
"""Test existence of warps."""
self.check_pipetasks(["makeWarp"], self._num_visits, self._num_visits)
def test_make_direct_warp(self):
"""Test existence of direct warps."""
self.check_pipetasks(["makeDirectWarp"], self._num_visits, self._num_visits)
self.check_datasets(["deepCoadd_directWarp"], self._num_visits)

def test_make_psfMatched_warp(self):
"""Test existence of PSF-matched warps."""
self.check_pipetasks(["makePsfMatchedWarp"], self._num_visits, self._num_visits)
self.check_datasets(["deepCoadd_psfMatchedWarp"], self._num_visits)

def test_assemble_coadd(self):
"""Test existence of coadds."""

Expand Down
Loading