DM-40171: Adapt test to accommodate 2 diffims with ~13% template coverage #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherner
reviewed
Oct 20, 2023
tests/test_validate_outputs.py
Outdated
| self.check_sources( | ||
| ["forced_diff", "forced_diff_diaObject"], | ||
| self._num_exposures_good_templates - self._num_forced_astrom_failures, | ||
| self._min_sources | ||
| num_expected_dia_successes, |
There was a problem hiding this comment.
This isn't a problem with the code, but is there any reason you made the num_expected_dia_successes variable here in the test_forced_phot_diffim function and passed that into check_sources, but didn't do the same in the test_image_difference or test_forced_source_tables functions? Of course the result's the same either way; just wondering about it from a consistency and ease of future bulk editing standpoint.
There was a problem hiding this comment.
Because this function used this value twice, and the other two used it once. Assigning a variable when you use it twice reduces lines of code/duplication. Assigning a variable when you use it once adds lines of code. That it is all.
kherner
approved these changes
Oct 20, 2023
and require DIA catalogs and forced source catalogs to have non-zero length rather than length > 100 like the source and coadd source catalogs do.
check_sources also checks datasets.
yalsayyad
force-pushed
the
tickets/DM-40171
branch
from
3ef5ef4
to
f76d707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.