Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45522 metrics: native timedelta support #319

Merged
merged 1 commit into from
Nov 6, 2024
Merged

DM-45522 metrics: native timedelta support #319

merged 1 commit into from
Nov 6, 2024
+12 −103

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Nov 6, 2024

Require a version of dataclasses-avroschema with native timedetla support, and remove the EventDuration custom pydantic type.

@fajpunk
DM-45522 metrics: Remove EventDuration, bump required `dataclasses-…
20ee113 
…avroschema`

Require a version of `dataclasses-avroschema` with native `timedetla`
support, and remove the `EventDuration` custom pydantic type.
@fajpunk fajpunk requested a review from rra November 6, 2024 16:48
rra
rra approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@fajpunk fajpunk merged commit 5da40c6 into main Nov 6, 2024
6 checks passed
@fajpunk fajpunk deleted the tickets/DM-45522/metrics-timedelta-builtin branch November 6, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rra rra rra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fajpunk @rra