Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Puppetfile) fix clustershell sha #1499

Merged
merged 1 commit into from
Oct 14, 2024
Merged

(Puppetfile) fix clustershell sha #1499

merged 1 commit into from
Oct 14, 2024

Conversation

glennmorris
Copy link
Contributor

The branch was rebased, and the old sha no longer exists.

@glennmorris
(Puppetfile) fix clustershell sha
32e6d51 
The branch was rebased, and the old sha no longer exists.
@glennmorris glennmorris added the bug Something isn't working label Oct 11, 2024
jhoblitt
jhoblitt approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we fork an upstream module, we should create either a tag or a branch for modifications that is intended to be static, that way this doesn't happen while trying to get changes upstreamed.

@jhoblitt jhoblitt merged commit 30c5ab3 into production Oct 14, 2024
11 of 12 checks passed
@jhoblitt jhoblitt deleted the IT-5729/clustershell branch October 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

@dtapiacl dtapiacl Awaiting requested review from dtapiacl

@cbarria cbarria Awaiting requested review from cbarria

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennmorris @jhoblitt