DO NOT MERGE: Refactor the top-most level of LSST metadetect #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
u/arunkannawadi/task_refactor_1
branch
from
42d9a64
to
15997c4
Compare
|
This is tracking the PR submitted upstream. It is intended to make it |
arunkannawadi
changed the title
arunkannawadi
force-pushed
the
u/arunkannawadi/task_refactor_1
branch
from
739e57f
to
313aac0
Compare
Co-authored-by: Ismael Mendoza <[email protected]>
Co-authored-by: Ismael Mendoza <[email protected]>
arunkannawadi
force-pushed
the
u/arunkannawadi/task_refactor_1
branch
from
c6cae7f
to
d058b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently refactors only the top-most level making
run_metadetect, which is the typical entry point, a wrapper around aTask. The extensive coverage with unit tests should make us all feel confident going about such refactoring. The fact that the the unit tests pass without any changes also shows that the public APIs remain unchanged.