Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46049: Add a Slack webhook to notify on failure #6

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

arunkannawadi
Copy link
Member

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update your codecov action.

I've never used the Slack webhook but I assume it works. I'm ignoring all the other unrelated changes.

@@ -60,3 +59,19 @@ jobs:
uses: codecov/codecov-action@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are going to want to update your codecov action to v4 and include the per-repo token (see daf_butler).

.github/workflows/lsst-tests.yml Outdated Show resolved Hide resolved
- lsst-tests
steps:
- uses: actions/checkout@v2
- name: Slack Notification
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never used this before so how does it know which channel to write to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add the app to any channel, or from the App management page I can add it to any channel.

@arunkannawadi
Copy link
Member Author

arunkannawadi commented Aug 29, 2024

Ignoring to review all the Python changes is fine. They are all from upstream and reviewed by Erin & Matt.

@arunkannawadi arunkannawadi changed the base branch from u/arunkannawadi/lsst-dev-sep3 to lsst-dev September 3, 2024 16:24
@arunkannawadi arunkannawadi merged commit 4d97e61 into lsst-dev Sep 3, 2024
7 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-46049 branch September 3, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants