-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-46049: Add a Slack webhook to notify on failure #6
Conversation
b4fd874
to
082a84b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to update your codecov action.
I've never used the Slack webhook but I assume it works. I'm ignoring all the other unrelated changes.
.github/workflows/lsst-tests.yml
Outdated
@@ -60,3 +59,19 @@ jobs: | |||
uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are going to want to update your codecov action to v4 and include the per-repo token (see daf_butler).
- lsst-tests | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Slack Notification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never used this before so how does it know which channel to write to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add the app to any channel, or from the App management page I can add it to any channel.
Ignoring to review all the Python changes is fine. They are all from upstream and reviewed by Erin & Matt. |
b742cf3
to
4d9c170
Compare
4d9c170
to
be6335a
Compare
No description provided.