-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-42534: Upload coverage report to Codecov #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. I didn't know about the .codecov.yml file.
.coveragerc
Outdated
@@ -0,0 +1,8 @@ | |||
[report] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put this in pyproject.toml since that's where we are going to end up and it saves proliferating lots of bespoke config files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. And I moved the config from .flake8
to setup.cfg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided against moving to setup.cfg
and chose to keep .flake8
to keep in sync with the repo upstream.
.github/workflows/lsst-tests.yml
Outdated
- name: Upload coverage reports to Codecov | ||
uses: codecov/codecov-action@v3 | ||
env: | ||
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this when it moves to lsst org (and I don't see why we can't enable lsst-dm org like lsst org).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched it to report in XML format and upload the file. No token required.
7096311
to
c041262
Compare
Always glad when someone learns something new from a PR! |
8e8a1e8
to
ac6b88b
Compare
efb7a7a
to
f3ce873
Compare
DM-42534: Upload coverage report to Codecov
DM-42534: Upload coverage report to Codecov
No description provided.