Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42534: Upload coverage report to Codecov #3

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

arunkannawadi
Copy link
Member

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I didn't know about the .codecov.yml file.

.coveragerc Outdated
@@ -0,0 +1,8 @@
[report]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this in pyproject.toml since that's where we are going to end up and it saves proliferating lots of bespoke config files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. And I moved the config from .flake8 to setup.cfg.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided against moving to setup.cfg and chose to keep .flake8 to keep in sync with the repo upstream.

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this when it moves to lsst org (and I don't see why we can't enable lsst-dm org like lsst org).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched it to report in XML format and upload the file. No token required.

@arunkannawadi arunkannawadi force-pushed the tickets/DM-42534 branch 2 times, most recently from 7096311 to c041262 Compare January 18, 2024 00:00
@arunkannawadi
Copy link
Member Author

I didn't know about the .codecov.yml file.

Always glad when someone learns something new from a PR!

@arunkannawadi arunkannawadi force-pushed the tickets/DM-42534 branch 2 times, most recently from efb7a7a to f3ce873 Compare January 18, 2024 22:13
@arunkannawadi arunkannawadi merged commit e0ea275 into lsst-dev Jan 19, 2024
6 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-42534 branch January 19, 2024 14:54
arunkannawadi added a commit that referenced this pull request Sep 3, 2024
DM-42534: Upload coverage report to Codecov
arunkannawadi added a commit that referenced this pull request Sep 3, 2024
DM-42534: Upload coverage report to Codecov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants