-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Configuration with Admin Page + Artemis Teams #124
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too large to review
server/application-server/src/main/java/de/tum/in/www1/hephaestus/OpenAPIConfiguration.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/admin/AdminController.java
Outdated
Show resolved
Hide resolved
server/application-server/src/main/java/de/tum/in/www1/hephaestus/admin/AdminController.java
Outdated
Show resolved
Hide resolved
<div class="flex flex-col items-start gap-4"> | ||
<div class="w-1/2"> | ||
<h2 class="text-lg font-semibold mb-2">Repositories to monitor:</h2> | ||
<textarea hlmInput [formControl]="repositoriesForm" class="block size-fit" style="field-sizing: content"></textarea> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like the textfield. Its is small and not easy to use, maybe we could have the repositories in a list of textfields, where you can edit each
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I should refactor this. At this point the PR is huge again, and there's so much stuff that could still be improved.
} | ||
]; | ||
|
||
@Component({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we cant edit the teams color, why have it in the table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it should probably be editable.
I personally would prefer doing follow-up PRs for stuff like this to avoid keeping the same PR open for many weeks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thats fine, then we just need to collect all points in a new issue so we dont forget some. :)
<hlm-td class="font-medium tabular-nums flex gap-4" *brnCellDef="let element"> | ||
@for (team of element.teams; track team) { | ||
@let label = { id: team.id, name: team.name, color: team.color ?? '69feff' }; | ||
<app-github-label [label]="label" [isLoading]="this.isLoading()" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label maybe clickable for removal
server/application-server/src/main/java/de/tum/in/www1/hephaestus/gitprovider/label/Label.java
Show resolved
Hide resolved
We also need a LiquiBase:diff changeLog I think. |
Could you give me a quick overview for the workflow regarding Liquibase? I assume |
This file should be renamed and commited + added to the history. Please compare it with the Artemis codebase. If we don't commit it the server will not update its schema. In the future we can squash the changelog again if it gets too long. |
Motivation
To accomodate for long-running production deployments, we want to be able to change the application configuation during runtime while keeping it persistent.
Instead of separating the leaderboard via repositories, we want to group users teams to acknowledge cross-repository development.
Description
/admin
/admin/users
Follow-Ups
Refer to #160
Testing Instructions
application-server
andwebapp
application-server
and control if your changes were persistedScreenshots (if applicable)
Checklist
General
Client (if applicable)
Server (if applicable)