[dv] Exclude some secded generation modules from coverage #25074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is slightly extending commit 803eed8, which excluded two secded decoders. For similar reasons, we might want to exclude the corresponding encoders. Again, these are verified in FPV and getting complete conditional coverage is hard (or maybe impossible) to hit. No need to spend time on doing so: the FPV should catch any bug in these prims. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
requested review from
hcallahan-lowrisc
and removed request for
a team
hcallahan-lowrisc
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
This makes sense to me. It probably would have saved some time for many doing gap analysis! Thanks @rswarbrick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is slightly extending commit 803eed8, which excluded two secded decoders. For similar reasons, we might want to exclude the corresponding encoders. Again, these are verified in FPV and getting complete conditional coverage is hard (or maybe impossible) to hit. No need to spend time on doing so: the FPV should catch any bug in these prims.