✨ Add support to query encrypted data #479
Open
+8,147
−539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAMIBETTAYEB
requested review from
agnes512,
dhmlau,
emonddr and
jannyHou
as code owners
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
SAMIBETTAYEB
force-pushed
the
development
branch
2 times, most recently
from
32b572b
to
001a9d9
Compare
dhmlau
reviewed
Jun 21, 2021
There was a problem hiding this comment.
@SAMIBETTAYEB, thanks for the PR. Could you please add some tests to verify your changes? Also, please sign the DCO as well. Thanks!
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "loopback-connector-postgresql", | |||
| "version": "3.9.1", | |||
| "version": "3.10.0", | |||
There was a problem hiding this comment.
there's no need for this change. When we publish a new version, the tool will update it for us.
|
You can sign the DCO by running the following command: Reference: https://loopback.io/doc/en/contrib/code-contrib.html. |
SAMIBETTAYEB
force-pushed
the
development
branch
4 times, most recently
from
ba6206a
to
e795527
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Do any of the reviewers verify it, please? |
|
Hi @sam-github, could you rebase your PR against the latest copy of master? That way the CI pipeline can be triggered. |
SAMIBETTAYEB
force-pushed
the
development
branch
from
2a7973e
to
3ce7d86
Compare
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Seems like syntax error: - autoupdate not working due to variable is unset - without this change (just comment this line) Indexes was not updated Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
* chore: set package-lock=false in .npmrc (Aidan Harbison) * Extends test structure to cover fix (Viktor Shanin) * Fix Index upgrade (Viktor Shanin) * fix: jsdoc (loopbackio#385) (Janny) * Enable Travis CI integration (Miroslav Bajtoš) * Manually fix remaining linting violations (Miroslav Bajtoš) * Auto-fix linting violations (Miroslav Bajtoš) * Update eslint to ^6.0.1 (Miroslav Bajtoš) * Update dev-dependencies (Miroslav Bajtoš) Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Run `eslint --fix .` to add trailing commas to function arguments. Signed-off-by: Miroslav Bajtoš <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Rapidly-fired queries can exhaust the pool capability and lead to odd results. In test, we've witnessed "Connection Terminated" flakiness with many fast test suites. This, combined with setting `lazyConnect: true` and `idleTimeoutMillis: 0`, alleviates the issue. Signed-off-by: SAMI BETTAYEB <[email protected]>
* fix(pool): synchronously release pool connection (Samuel Reed) * Handler for with(out) time zone time(stamp) types (Stefano Pirra) * chore: improve issue and PR templates (Nora) * chore: exclude "good first issues" from stalebot (Miroslav Bajtoš) * Fix eslint violations (Miroslav Bajtoš) Signed-off-by: SAMI BETTAYEB <[email protected]>
Array properties are represented as juggler `List` instance, we need to modify test assertions to convert them via `toArray()` before applying `.should.eql` check. Signed-off-by: Miroslav Bajtoš <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
* test: clean test for `contains` operator (Miroslav Bajtoš) * test: fix array tests to handle List values (Miroslav Bajtoš) * docs: improve README organization (Miroslav Bajtoš) * feat: adds 'contains' operator for querying arrays (shubhisood) Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Raymond Feng <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
* Ensure order of and/or clauses are preserved (Raymond Feng) Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Matthew Gabeler-Lee <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
* fix: enable pool error handling (Matthew Gabeler-Lee) Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Francisco Buceta <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
This reverts commit e3ba700. Signed-off-by: Miroslav Bajtoš <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Agnes Lin <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Agnes Lin <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
* Add on delete options on FK constraints (Quentin Le Bour) * ci: switch from Travis to Github Actions (Agnes Lin) * Revert "ci: switch travis to github actions" (Miroslav Bajtoš) * ci: switch travis to github actions (Francisco Buceta) Signed-off-by: SAMI BETTAYEB <[email protected]>
When `PostgreSQL.prototype.getDropForeignKeys` gets called with duplicated foreign keys, an invalid `ALTER TABLE` statement gets created. This is because the duplicates are mapped to multiple `DROP CONSTRAINT fk_key` SQL actions, e.g.: ```sql -- This will throw an error ALTER TABLE "public"."foo" DROP CONSTRAINT "fk_duplicatedKey", DROP CONSTRAINT "fk_duplicatedKey", DROP CONSTRAINT "fk_duplicatedKey", DROP CONSTRAINT "fk_otherKey" ``` As the `DROP CONSTRAINT` actions are run sequentially, when the first action gets executed by PostgreSQL, the next one (for the same, but already dropped key) will not cause an SQL error thanks to the added IF EXISTS check: ```sql -- This is valid SQL ALTER TABLE "public"."foo" DROP CONSTRAINT IF EXISTS "fk_duplicatedKey", DROP CONSTRAINT IF EXISTS "fk_duplicatedKey", DROP CONSTRAINT IF EXISTS "fk_duplicatedKey", DROP CONSTRAINT IF EXISTS "fk_otherKey" ``` Please note, this is really a hack and we still need to understand why the method in question gets called with duplicated foreign keys in certain conditions. Signed-off-by: Chris Kobrzak <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: Diana Lau <[email protected]> Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
Signed-off-by: SAMI BETTAYEB <[email protected]>
SAMIBETTAYEB
force-pushed
the
development
branch
from
3ce7d86
to
9beef0c
Compare
|
@achrinza, done! |
|
Can any of the reviewers verify the PR, please? |
|
Apologies @SAMIBETTAYEB, I didn't realise that this PR was targeting 3.x instead of master. I'll cherry-pick the commits into new PRs. |
|
Thank you @achrinza, waiting for your review. |
|
Thanks, @SAMIBETTAYEB; Would you be able to point this PR to the master branch (v5.x)? Or is 3.x necessary? Based on what I can tell, 5.x supports both LB3 and LB4. |
|
Yep @achrinza, I think it will be. |
|
Thanks, @SAMIBETTAYEB. If you're comfortable with performing this, could you please reset the branch against master, then cherry-pick the commit range you intend to submit? The commands should look similar to this: $ git reset --hard upstream/master # Assuming you've set `upstream` remote to loopbackio/loopback-connector-postgresql
$ git cherry-pick 1199248a0a3e2881241e01d970bb1411605bfead...9beef0c353f335731e498fe262f6daac50012103
# Fix any merge conflicts
git add --all
git cherry-pick --continue
# Repeat last 2 steps for each commit with a merge conflict
# Push changes to remote
$ git push --force-with-leasePlease adjust the commands above according to your Git setup if necessary. For a wrost-case scenario, I've created a 'backup' of your original commits at #486 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature about querying encrypted fields.