feat: initSdk helper fn in @looker/extension-utils #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
josephaxisa
force-pushed
the
jax/ext-utils-sdk-utils
branch
from
7ccdca7
to
b50e8c2
Compare
APIX Tests 1 files 78 suites 3m 15s ⏱️ Results for commit f029e62. |
Typescript Tests 7 files 76 suites 4m 2s ⏱️ Results for commit f029e62. |
jkaster
requested changes
Feb 22, 2022
| /** Id used to register this application on the Looker server */ | ||
| clientId: string | ||
| /** A callback function that returns an sdk instance */ | ||
| createSdkCallback: (session: BrowserSession) => APIMethods |
There was a problem hiding this comment.
Can this return IAPIMethods instead? Is there something in APIMethods that's not documented in IAPIMethods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.