feat: allow duplicate values for URL params

[eino]

Allow duplicate same-named params, so as to support multiple hide_filter.

Fixes #151 , Fixes #159

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[tmarnet]

I would love to see this being merged 🙂

How can we make this happen ?

[bryans99]

Overall this is a very good change (I saw it when it first came in).

I actually started looking at it myself but went down a rabbit hole looking at other things that might benefit from this change.

Have a look at the LookerEmbedFilterParams type. Should we do the same thing to it, i.e is it okay to have filters of the same name?

I'm gonna approve but think about looking into the above before merging.

[deepakshukla-bidgely]

Hi @eino, since @bryans99 approved the PR can you please go ahead and merge this change?

[eino]

Hi @bryans99 , thanks for the heads-up. Indeed a similar change should probably be applied to LookerEmbedFilterParams. I will try to check if the format is the same.

In parallel, could you check this MR ? the build and doccheck check are not launching, stuck in "Expected" (so the MR is not mergeable). Do you know where it could come from ?

[lambdamusic]

Hello - is there any technical issue holding this up?

Just wondering because we'd love to have this functionality!

[drstrangelooker]

Merging into local branch for testing.

[lambdamusic]

Many thanks @drstrangelooker !

Do you have any info on when a new npm package will be released including this feature?

We'd really love to make use of this functionality. Currently though the MR seems to be blocked by the documentation not building?