Flesh out readme a bit more #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add link to the underlying repo (for folks like me who had difficulty figuring out how to get from the doc content to the actual repo)
whscullin
reviewed
Oct 17, 2019
|
|
||
| ```html | ||
| src=https://looker.example.com:443/embed/dashboards/11?sdk=2&embed_host=https://yourhost.example.com | ||
| src=https://looker.example.com:443/embed/dashboards/11?param=data&etc=etc&signature=ADSFWE$WEDASDFWE#WSADS |
There was a problem hiding this comment.
Wrong direction. The is the URL to be signed, not the signed URL. It will now look like /embed/dashboards/11?param=data&etc=etc because of the lack of fully qualified embed URLs now.
| ### Web App Setup | ||
| The Looker Embed SDK is a JavaScript module that lives and runs in the browser with your web app. | ||
|
|
||
| The demo also includes a reference implementation of the Looker SSO embed URL signature algorithm as a NodeJS web server module. The URL signature is used to secure and authenticate the embed URL request on the Looker server. |
There was a problem hiding this comment.
There's a python demo server as well.
|
|
||
| The demo also includes a reference implementation of the Looker SSO embed URL signature algorithm as a NodeJS web server module. The URL signature is used to secure and authenticate the embed URL request on the Looker server. | ||
|
|
||
| The instructions and demo web app shown below assume that the Looker Embed SDK is built into your web app using the included webpack build configuration. If your web app doesn't use the webpack stack, you can build the Embed SDK into a javascript module and then reference that module from your web app HTML. |
There was a problem hiding this comment.
We don't assume Webpack. It's a UMD format module that should work with most Javascript module toolchains.
| ``` | ||
|
|
||
| ### Node helper | ||
|
|
||
| A signing helper method `createSignedUrl()` is provided in | ||
| [server_utils/auth_utils.ts](blob/master/demo/demo_config.ts). Its usage is as follows: | ||
| This Embed SDK includes a reference implementation of the required URL signing algorithm in a NodeJS server module. The signing function is `createSignedUrl()` in file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add link to the underlying repo (for folks like me who had difficulty figuring out how to get from the doc content to the actual repo)