Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support signed embed urls during backend session creation #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-lopes-optimizely

This would unblock our team's use case, where we want to exclusively initiate a session for a particular LookML component (e.g. dashboard) and because there's sensitive information we don't want to pass to the frontend to generate the url , we need to generate the embed signed url in the backend and pass it back to the frontend running Embed SDK.

Let me know if this is PR is enough or if we need any additional work done; this is quite important for us.

We're in contact with the Looker Engineering team, so they can also provide information over our several use cases that are out of norm and may require additional context.

@google-cla
Copy link

google-cla bot commented Aug 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@daniel-lopes-optimizely daniel-lopes-optimizely changed the title Support signed embed urls during backend session creation feat: support signed embed urls during backend session creation Aug 18, 2023
@daniel-lopes-optimizely daniel-lopes-optimizely force-pushed the singed-embed-url branch 2 times, most recently from 3e08a5f to f0262e6 Compare August 18, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant