Adding wasSuccessful param to TransactionObservabilityManager #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGamero
requested review from
kibertoad,
drdaemos and
a team
as code owners
kibertoad
reviewed
Aug 29, 2024
| @@ -23,6 +23,7 @@ export type TransactionObservabilityManager = { | |||
| /** | |||
| * Ends the transaction | |||
| * @param uniqueTransactionKey - used for identifying specific ongoing transaction. Must be reasonably unique to reduce possibility of collisions | |||
| * @param wasSuccessful - indicates if the transaction was successful or not | |||
There was a problem hiding this comment.
should we default to true?
There was a problem hiding this comment.
The advantage of the optional value is that it lets different implementations define what means "default value" instead of forcing them to have true.
But I am not really sure if it has more const (or more important ones) than pros, so please feel free to disagree and I will change it, no strong opinion from my side
There was a problem hiding this comment.
fair point, it should be handled on an implementation side
kibertoad
approved these changes
Aug 29, 2024
CarlosGamero
deleted the
feat/transaction_bbservability_manager_stop_new_param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some transaction observability tools, might be beneficial to know if a transaction was successful or not, improving API to support it
Checklist
major,minor,patchorskip-release