Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go and alipne #120

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Upgrade go and alipne #120

merged 1 commit into from
Oct 3, 2023

Conversation

yarlson
Copy link
Collaborator

@yarlson yarlson commented Oct 3, 2023 •
edited
Loading

  • Upgraded Go version to 1.21.
  • Updated Alpine in docker images to v3.18.
  • Addressed and fixed depreciation warnings in codebase.
  • Upgraded Lokalise SDK to v3.4.0.
  • Enhanced Docker images to support multi-architecture: both amd64 and arm64.

@yarlson yarlson force-pushed the go-alpine-upgarde branch 3 times, most recently from 8398fb8 to 1562947 Compare October 3, 2023 10:30
asaphko
asaphko reviewed Oct 3, 2023
View reviewed changes
README.md Outdated
@@ -123,7 +123,14 @@ Optionally, you may rename included `config-example.yml` to `config.yml` and set
Only one concurrent request per token is allowed.

## Changes
**2.6.8 (Oct 21, 2021)**
**2.6.9 (Oct 21, 2021)**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date typo?

@yarlson yarlson marked this pull request as ready for review October 3, 2023 10:35
@asaphko
Copy link

asaphko commented Oct 3, 2023

Tested locally with Go:

go build -o lokalise2 main.go ./lokalise2 --token c2a9.....274f4 --project-id 98239...358 file download --format json --unzip-to ./

And tested building the Docker image and running:

docker run -v /tmp/locale:/opt/dest lokalise-cli-upgraded lokalise2 --token c2a916....61f9d05274f4 --project-id 9823...62358 file download --format json --unzip-to /opt/dest

Both work correctly.

@yarlson i don't think i have permission to approve this PR in this repo.

@yarlson yarlson merged commit 1b7e4c7 into master Oct 3, 2023
2 checks passed
@yarlson
Copy link
Collaborator Author

yarlson commented Oct 3, 2023

Fixes #117 as well

@yarlson yarlson mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaphko asaphko asaphko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarlson @asaphko