Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RONDB-628: Build ARM in CI for Release Builds #447

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/build-deploy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: build-deploy

on:
# Launch on manual trigger
workflow_dispatch:
push:
branches:
- 22.10.[0-9]+
- 21.04.[0-9]+
# TODO: Remove this once done with testing
pull_request:
# Not running on "closed" - that is taken care of by "push" (if merged)
types: [opened, synchronize, reopened]

jobs:
build-deploy:
# if: github.repository == 'logicalclocks/rondb'
runs-on: macos-14-xlarge

steps:
- name: Checkout main repo
uses: actions/checkout@v4

- name: Build with Docker
run: |
export DOCKER_CLI_EXPERIMENTAL=enabled
export BUILDKIT_PROGRESS=plain

docker buildx build . \
-f Dockerfile.ubuntu22 \
--tag rondb-build-all:22.10.1 \
--target build-all \
--no-cache \
--build-arg BUILD_THREADS=$BUILD_CORES \
--build-arg RELEASE_TARBALL=1 # \
# --build-arg RELEASE_FINAL_CLUSTERJ=1 \
# --build-arg DEPLOY_TO_REPO=1 \
10 changes: 8 additions & 2 deletions build_scripts/release_scripts/build_gen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ if [[ -z "$TYPE" || -z "$SRC_DIR" || -z "$INSTALL_DIR" ]]; then
exit 1
fi

CPU_ARCH=$(uname -m)

ADDITIONAL_FLAGS=""

# Enabling additional security checks in standard library functions to protect against buffer
Expand Down Expand Up @@ -42,7 +44,9 @@ if test -f "$HARDENED_CC1"; then
fi

#-m64: This flag specifies that the code should be compiled for a 64-bit target platform.
ADDITIONAL_FLAGS="${ADDITIONAL_FLAGS} -m64"
if [ "$CPU_ARCH" != "amd64" ]; then
ADDITIONAL_FLAGS="${ADDITIONAL_FLAGS} -m64"
fi

# -mtune=generic: This flag tells the compiler to optimize code for a generic (i.e.,
# not architecture-specific) target.
Expand All @@ -59,7 +63,9 @@ ADDITIONAL_FLAGS="${ADDITIONAL_FLAGS} -fstack-clash-protection"

# -fcf-protection: This flag adds control flow protection to protect against various
# control flow attacks.
ADDITIONAL_FLAGS="${ADDITIONAL_FLAGS} -fcf-protection"
if [ "$CPU_ARCH" != "amd64" ]; then
ADDITIONAL_FLAGS="${ADDITIONAL_FLAGS} -fcf-protection"
fi

COMMON_OPTIONS=(
"-DCMAKE_C_FLAGS='${CMAKE_C_FLAGS} ${ADDITIONAL_FLAGS}'"
Expand Down
Loading