Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overscroll mobile + tests #232

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Fix overscroll mobile + tests #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e775d0
Fix bug where stars given was not output correctly
DanielJackson-Oslo Feb 29, 2024
399286a
Fix bug where sr-only caused reviews to overflow. They need to be ins…
DanielJackson-Oslo Feb 29, 2024
f8b4a84
Fix brittle test. have_text does not wait for JS to run. Have_content…
DanielJackson-Oslo Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/reviews/_review_content.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<% show_full_review = false unless defined?(:show_full_review) %>

<h3 class="reset-header-styles">
<span class="font-bold flex gap-1">
<span class="font-bold inline-flex gap-1 relative">
<%= inline_svg_tag 'star', class: 'text-pink-600' if review.star_rating %>
<%= review.star_rating %>
<span class="sr-only"><%= t("reviews.stars_given", count: review.star_rating) %></span>
<span class="sr-only"><%= t("reviews.stars_given", count: review.star_rating.to_i) %></span>
<% unless review.star_rating %>
-
<% if review.type_of_contact %>
Expand Down
4 changes: 2 additions & 2 deletions spec/features/user_manages_space_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@
fill_in "space_post_number", with: space.post_number
find("body").click # Blur from field

expect(page).to have_text(I18n.t("space_create.any_of_these.one"))
expect(page).to have_content(I18n.t("space_create.any_of_these.one"))

click_on I18n.t("space_create.none_are_duplicates.one")

tom_select("select#space_space_type_ids", option_id: space_type.id)
tom_select("select#space_space_group_title", option_id: space_group.title)
click_on I18n.t("helpers.submit.create", model: Space.model_name.human)
expect(page).to have_text(space.title)
expect(page).to have_content(space.title)
end
end

Expand Down
Loading