Combine after_save and after_destroy to after_commit

lnu-norge · Mar 2, 2024 · d48c546 · d48c546
1 parent b84f71d
commit d48c546
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/app/models/space_types_facility.rb b/app/models/space_types_facility.rb
@@ -4,13 +4,7 @@ class SpaceTypesFacility < ApplicationRecord
   belongs_to :space_type
   belongs_to :facility
 
-  after_create do
-    space_type.reload.spaces.each do |space|
-      space.reload.aggregate_facility_reviews(facilities: [facility])
-    end
-  end
-
-  after_destroy do
+  after_commit do
     space_type.reload.spaces.each do |space|
       space.reload.aggregate_facility_reviews(facilities: [facility])
     end

diff --git a/app/models/space_types_relation.rb b/app/models/space_types_relation.rb
@@ -4,11 +4,7 @@ class SpaceTypesRelation < ApplicationRecord
   belongs_to :space_type
   belongs_to :space
 
-  after_save do
-    space.reload.aggregate_facility_reviews(facilities: space_type.facilities)
-  end
-
-  after_destroy do
+  after_commit do
     space.reload.aggregate_facility_reviews(facilities: space_type.facilities)
   end
 end