Polling (maybe?) #10
Draft
Polling (maybe?) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sockfd was being passed to the printf calls in place of the thread ID. While this version of NuttX does not yet have gettid(), its getpid() actually implements the semantics of gettid(), and returns the thread ID, so we can use it in the error messages. Furthermore, the return value for recv() would always be -1, so printing errno is what helps us in determining the error cause.
Having the workers themselves increment the worker count can lead the main server function to start more servers than it should, if it runs before the thread is able to increment the count.
We have observed empirically that the socket timeout doesn't always work, due to some condition reached by the firmware. This is an attempt at using a different codepath, which might be more reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit is optional and I'm still not sure it's necessary. I don't understand what's going on right now with the timeout not working after some time...
I have enabled all RFFE IOCs to try and reproduce the issue better...