-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: move test lnd logs to a more permanent location #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable! We're also going to want these logs uploaded as an artifacts in GH actions so that we can see what's failing (generally slower CI machines tend to flake a lot more so local copies often aren't enough). Can we look into that here as well?
a72a0e2
to
e982482
Compare
3f14cba
to
5434ce8
Compare
e982482
to
2c6fa55
Compare
5434ce8
to
554cb0f
Compare
554cb0f
to
8ddf253
Compare
8ddf253
to
f79354a
Compare
f79354a
to
346c068
Compare
@carlaKC ok I added the github action for uploading the logs :) I also now included the ldk logs since this PR for setting the ldk logs elsewhere is now merged lightningdevkit/ldk-node#129 |
346c068
to
b1049cd
Compare
b1049cd
to
4af0d0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
The comment is optional if you'd like some other ldk-node fixes in but don't they actually affect us.
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] } | ||
flate2 = "1.0.25" | ||
ldk-node = "0.1.0" | ||
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "3a31209" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's quickly get in some of the other bug fixes :)
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "3a31209" } | |
ldk-node = { git = "https://github.com/lightningdevkit/ldk-node", rev = "77acd3b" } |
Replaced by #70 |
Here's a first stab at drafting a solution for storing logs, as discussed with @carlaKC in #58 . The code changes are pretty small, but a couple notes below on implementation, including a change to LDK that we need to do to get this fully working.
A couple of notes on implementation: