Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(exporter-variables-scss): Typography generator function use one object #1662

Closed
wants to merge 42 commits into from

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 26, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6cebe77
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66f545cefcb71f00088a649f
😎 Deploy Preview https://deploy-preview-1662--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 6cebe77
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66f545ceecba97000888f602
😎 Deploy Preview https://deploy-preview-1662--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.732%. remained the same
when pulling 6cebe77 on refactor/exporter-js
into 74ffbad on feat/ds-1437-export-into-js.

@curdaj curdaj force-pushed the feat/ds-1437-export-into-js branch 3 times, most recently from 3e74fac to 8a8f76e Compare September 26, 2024 13:38
@literat literat closed this Sep 26, 2024
@literat literat deleted the refactor/exporter-js branch September 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants