Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Introduce Footer component #DS-1368 #1657

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Feat(web-react): Introduce Footer component #DS-1368 #1657

merged 3 commits into from
Sep 27, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Sep 23, 2024 •
edited
Loading

Description

Additional context

Preview links:

React:
Preview

Storybook:
Preview

Storybook composition:
Preview

Issue reference

Komponenta Footer | Web-React

@pavelklibani pavelklibani self-assigned this Sep 23, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 23, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d870e6e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66f5725dead318000819cc32
😎 Deploy Preview https://deploy-preview-1657--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit d870e6e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66f5725d26f8d300083aeeb4
😎 Deploy Preview https://deploy-preview-1657--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.748% (+0.02%) from 78.732%
when pulling 1878463 on feat/ds-1368-react-footer
into 4ab9f62 on main.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 78.748% (+0.02%) from 78.732%
when pulling 1878463 on feat/ds-1368-react-footer
into 4ab9f62 on main.

@coveralls
Copy link

Coverage Status

coverage: 78.748% (+0.02%) from 78.732%
when pulling 1878463 on feat/ds-1368-react-footer
into 4ab9f62 on main.

@coveralls
Copy link

coveralls commented Sep 23, 2024 •
edited
Loading

Coverage Status

coverage: 78.761% (+0.03%) from 78.732%
when pulling d870e6e on feat/ds-1368-react-footer
into afe5319 on main.

@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10989484975/artifacts/1964865669

literat
literat requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use design system components like Link or Heading where possible.

@pavelklibani pavelklibani force-pushed the feat/ds-1368-react-footer branch 2 times, most recently from f88fb51 to 4dda7e2 Compare September 24, 2024 14:09
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11030730431/artifacts/1976156342

literat
literat approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👍

crishpeen
crishpeen requested changes Sep 26, 2024
View reviewed changes
packages/web-react/src/components/Footer/demo/FooterNested.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/demo/FooterNested.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/demo/FooterDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/demo/FooterDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/demo/FooterDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
crishpeen
crishpeen approved these changes Sep 26, 2024
View reviewed changes
packages/web-react/docs/stories/examples/FooterContent.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/demo/FooterDefault.tsx Outdated Show resolved Hide resolved
adamkudrna
adamkudrna reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with Storybook! 👏🏻 Beautifully done. 👍🏻

I have just two points to this:

  1. Please hide the classes of the <Footer> component inside its internal implementation.
  2. Just an idea: is there any benefit in turning the most complicated parts (navigation section, secondary links) into subcomponents of Footer?

packages/web-react/src/components/Footer/README.md Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web-react/docs/stories/examples/FooterContent.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/docs/stories/examples/FooterContent.stories.tsx Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Show resolved Hide resolved
packages/web-react/src/components/Footer/README.md Show resolved Hide resolved
@pavelklibani pavelklibani merged commit c9d35e3 into main Sep 27, 2024
17 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1368-react-footer branch September 27, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat approved these changes

@crishpeen crishpeen crishpeen approved these changes

@curdaj curdaj curdaj approved these changes

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pavelklibani @coveralls @literat @adamkudrna @crishpeen @curdaj