Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use alt and <title> in UNSTABLE_PartnerLogo and UNSTABLE_ProductLogo #1651

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

adamkudrna
Copy link
Contributor

Description

Use the alt attribute and <title> tag to make the inside images accessible.

Issue reference

Discovered in #1618.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 1f0eb2b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ec3832b6238d0008bcda5b
😎 Deploy Preview https://deploy-preview-1651--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Sep 17, 2024
@adamkudrna
Copy link
Contributor Author

Maybe the first line of the commit message could be better.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 1f0eb2b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ec38326c4b51000857808c
😎 Deploy Preview https://deploy-preview-1651--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 78.732%. remained the same
when pulling 1f0eb2b on fix/product-and-partner-logo
into b04f824 on main.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaa, doing it in the v3 integration branch would save us (me) a lot of work during the rebase :D

@curdaj
Copy link
Contributor

curdaj commented Sep 18, 2024

ParterLogo and ProductLogo are already stabilized in integration/BC-v3-design-tokens

…ABLE_ProductLogo`

Use the `alt` attribute and `<title>` tag to make the inside images accessible.
… `UNSTABLE_ProductLogo`

Use the `alt` attribute and `<title>` tag to make the inside images accessible.
@adamkudrna adamkudrna merged commit 4ab9f62 into main Sep 19, 2024
17 checks passed
@adamkudrna adamkudrna deleted the fix/product-and-partner-logo branch September 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants