-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Use alt
and <title>
in UNSTABLE_PartnerLogo
and UNSTABLE_ProductLogo
#1651
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maybe the first line of the commit message could be better. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaaa, doing it in the v3 integration branch would save us (me) a lot of work during the rebase :D
packages/web/src/scss/components/UNSTABLE_PartnerLogo/README.md
Outdated
Show resolved
Hide resolved
ParterLogo and ProductLogo are already stabilized in |
…ABLE_ProductLogo` Use the `alt` attribute and `<title>` tag to make the inside images accessible.
… `UNSTABLE_ProductLogo` Use the `alt` attribute and `<title>` tag to make the inside images accessible.
b7e8db7
to
1f0eb2b
Compare
Description
Use the
alt
attribute and<title>
tag to make the inside images accessible.Issue reference
Discovered in #1618.