Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Switch TextArea component to v3 design tokens #DS-1447 #1636

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 12, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 78.659%. remained the same
when pulling 7340634 on feat/v3-textarea
into 3567c63 on feat/v3-textfield.

@coveralls
Copy link

coveralls commented Sep 12, 2024

Coverage Status

coverage: 78.657% (-0.8%) from 79.418%
when pulling 898345e on feat/v3-textarea
into e4c8059 on integration/BC-v3-design-tokens.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 898345e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e9747ca868c9000837ca02
😎 Deploy Preview https://deploy-preview-1636--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 898345e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e9747c8a14cf0008e1a8fb
😎 Deploy Preview https://deploy-preview-1636--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@crishpeen crishpeen force-pushed the feat/v3-textfield branch 2 times, most recently from 0cecb64 to f0ea8fe Compare September 17, 2024 09:09
Base automatically changed from feat/v3-textfield to integration/BC-v3-design-tokens September 17, 2024 11:37
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@crishpeen crishpeen merged commit c0b2966 into integration/BC-v3-design-tokens Sep 17, 2024
23 checks passed
@crishpeen crishpeen deleted the feat/v3-textarea branch September 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants