Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(variables-scss): Support for themes #DS-1436 #1626

Merged

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Sep 9, 2024

Description

Additional context

Issue reference

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5deef76
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e036970d9a3f0008978e20
😎 Deploy Preview https://deploy-preview-1626--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Sep 9, 2024
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5deef76
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e03697fd2c6b0008e5f62b

@curdaj curdaj marked this pull request as ready for review September 9, 2024 12:26
@coveralls
Copy link

coveralls commented Sep 9, 2024

Coverage Status

coverage: 78.698%. remained the same
when pulling 5deef76 on feat/ds-1436-support-for-themes
into d519195 on feat/ds-1461-formatting-colors.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add all the indexes to themes and @themes.scss file

@curdaj curdaj force-pushed the feat/ds-1461-formatting-colors branch 2 times, most recently from 36b2095 to d519195 Compare September 10, 2024 11:42
@curdaj curdaj force-pushed the feat/ds-1436-support-for-themes branch from 5362c8f to d8c587b Compare September 10, 2024 11:46
@curdaj curdaj force-pushed the feat/ds-1436-support-for-themes branch from d8c587b to 5deef76 Compare September 10, 2024 12:07
@curdaj curdaj merged commit a4eeacf into feat/ds-1461-formatting-colors Sep 10, 2024
21 checks passed
@curdaj curdaj deleted the feat/ds-1436-support-for-themes branch September 10, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants