Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Switch Accordion component to v3 design tokens #DS-1451 #1611

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

crishpeen
Copy link
Member

Description

Visual tests are blocked until Pill is updated too.

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 3, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 215f5ba
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e038890d9a3f000898f107
😎 Deploy Preview https://deploy-preview-1611--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

Changes unknown
when pulling 215f5ba on feat/v3-accordion
into ** on integration/BC-v3-design-tokens**.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 3 times, most recently from 43ae363 to 416f055 Compare September 5, 2024 09:29
@crishpeen crishpeen force-pushed the feat/v3-accordion branch 2 times, most recently from b69b021 to d536003 Compare September 5, 2024 11:47
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 240831b to b3961b8 Compare September 5, 2024 15:09
@crishpeen crishpeen force-pushed the feat/v3-accordion branch 2 times, most recently from 0880545 to c102b6e Compare September 6, 2024 08:11
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 215f5ba
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e03889ba4f1e00087bf525
😎 Deploy Preview https://deploy-preview-1611--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen merged commit 1c9457f into integration/BC-v3-design-tokens Sep 10, 2024
15 checks passed
@crishpeen crishpeen deleted the feat/v3-accordion branch September 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants