Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Switch Radio component to v3 design tokens #DS-1447 #1609

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Feat(web): Switch Radio component to v3 design tokens #DS-1447 #1609

merged 1 commit into from
Sep 17, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 2, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6a7df65
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e973d66ae1880008214a8b
😎 Deploy Preview https://deploy-preview-1609--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 2, 2024 •
edited
Loading

Coverage Status

coverage: 78.657% (-0.8%) from 79.418%
when pulling 6a7df65 on feat/v3-radio
into e4c8059 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 2 times, most recently from fc61244 to c677111 Compare September 5, 2024 09:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10718053521/artifacts/1895539403

@literat
Copy link
Collaborator

literat commented Sep 6, 2024

Please check a web-react demo. It looks like there is some problem with radio ids, or something because the radio is not switching on the first click (tested in desktop chrome).

Also from my point of view, there is a problem with colors. I cannot distinguish between normal and disabled radio.

@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 6a7df65
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e973d66aefc30008dee61d
😎 Deploy Preview https://deploy-preview-1609--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10794277697/artifacts/1914626098

literat
literat approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the feat/v3-radio branch 2 times, most recently from 559e437 to 97c0622 Compare September 12, 2024 11:31
@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 2 times, most recently from 67faa98 to a433f13 Compare September 17, 2024 06:41
Base automatically changed from feat/v3-checkbox to integration/BC-v3-design-tokens September 17, 2024 08:46
@crishpeen crishpeen force-pushed the feat/v3-radio branch 3 times, most recently from 1979090 to 6ca40b5 Compare September 17, 2024 11:40
adamkudrna
adamkudrna approved these changes Sep 17, 2024
View reviewed changes
packages/web/src/scss/components/Radio/_Radio.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Radio/_Radio.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Radio/_Radio.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Radio/_Radio.scss Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_form-fields.scss Show resolved Hide resolved
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@crishpeen crishpeen merged commit aa773ee into integration/BC-v3-design-tokens Sep 17, 2024
23 checks passed
@crishpeen crishpeen deleted the feat/v3-radio branch September 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@curdaj curdaj curdaj approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @adamkudrna @curdaj