Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Switch Checkbox component to v3 design tokens #DS-1447 #1607

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Feat(web): Switch Checkbox component to v3 design tokens #DS-1447 #1607

merged 2 commits into from
Sep 17, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Aug 31, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 31, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 22475dc
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e925ed189801000861af18
😎 Deploy Preview https://deploy-preview-1607--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Aug 31, 2024
@coveralls
Copy link

coveralls commented Sep 2, 2024 •
edited
Loading

Coverage Status

coverage: 74.977% (-3.7%) from 78.659%
when pulling 22475dc on feat/v3-checkbox
into 46cb0d5 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 3 times, most recently from 43ae363 to 416f055 Compare September 5, 2024 09:29
@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 4 times, most recently from c677111 to 82edb8a Compare September 5, 2024 11:44
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 240831b to b3961b8 Compare September 5, 2024 15:09
@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 2 times, most recently from 0cf82e1 to 3ca9d6d Compare September 6, 2024 08:08
@literat
Copy link
Collaborator

literat commented Sep 6, 2024

Same for the Checkbox as for the Radio. The visual change between normal and disabled checkboxes is not enough. They look almost the same.

@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 22475dc
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e925edc79e870007830f7a

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10793746633/artifacts/1914483437

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10794013538/artifacts/1914561163

adamkudrna
adamkudrna reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Item variant needs to reviewed. Otherwise OK, I believe 🤞🏻.

tests/e2e/demo-components-compare.spec.ts Outdated Show resolved Hide resolved
packages/web/src/scss/theme/_form-fields.scss Outdated Show resolved Hide resolved
packages/web/src/scss/theme/_form-fields.scss Outdated Show resolved Hide resolved
packages/web/src/scss/theme/_form-fields.scss Show resolved Hide resolved
packages/web/src/scss/components/Checkbox/_Checkbox.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Checkbox/_Checkbox.scss Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10796106357/artifacts/1915169164

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10796625138/artifacts/1915324668

@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 2 times, most recently from ca5766c to d3679f6 Compare September 10, 2024 16:44
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10796943073/artifacts/1915418823

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 1026e5e to 9e0cf35 Compare September 11, 2024 09:22
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10808986712/artifacts/1918702985

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 9e0cf35 to 2c04230 Compare September 11, 2024 11:52
@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 5 times, most recently from c373648 to 9890995 Compare September 12, 2024 13:43
@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 2 times, most recently from 67faa98 to a433f13 Compare September 17, 2024 06:41
@crishpeen crishpeen merged commit 26afb16 into integration/BC-v3-design-tokens Sep 17, 2024
15 checks passed
@crishpeen crishpeen deleted the feat/v3-checkbox branch September 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@curdaj curdaj curdaj approved these changes

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani @curdaj