Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Switch Dropdown component to v3 design tokens #DS-1450 #1606

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Feat(web): Switch Dropdown component to v3 design tokens #DS-1450 #1606

merged 1 commit into from
Sep 3, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Aug 30, 2024
@github-actions github-actions bot added the feature New feature or request label Aug 30, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 3bd4256
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66d1e489dbefef000812569d
😎 Deploy Preview https://deploy-preview-1606--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 78 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.449%. remained the same
when pulling 3bd4256 on feat/v3-dropdown
into 2f258a6 on integration/BC-v3-design-tokens.

@crishpeen crishpeen merged commit 7c9ab21 into integration/BC-v3-design-tokens Sep 3, 2024
14 checks passed
@crishpeen crishpeen deleted the feat/v3-dropdown branch September 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@curdaj curdaj curdaj approved these changes

@literat literat Awaiting requested review from literat literat is a code owner

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @adamkudrna @pavelklibani @curdaj