Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Tooltip - fix reported bugs #1544

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

  • Fixed isOpen prop for UncontrolledTooltip
  • Fixed missing '#' in the data-spirit-target in the Twig documentation examples.

Additional context

Issue reference

Slack message

- Fixed 'isOpen' prop for UncontrolledTooltip
@pavelklibani pavelklibani self-assigned this Jul 15, 2024
@github-actions github-actions bot added the bug Something isn't working label Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 3030134
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/669529124f9d310008deb30e
😎 Deploy Preview https://deploy-preview-1544--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 3030134
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66952912c9cdfb0008b9473b
😎 Deploy Preview https://deploy-preview-1544--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 77.955% (+0.004%) from 77.951%
when pulling 3030134 on fix/tooltip-support-request
into bd48607 on main.

@pavelklibani pavelklibani merged commit f0d30cf into main Jul 17, 2024
30 checks passed
@pavelklibani pavelklibani deleted the fix/tooltip-support-request branch July 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants