Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(web, web-twig, web-react, e2e): Tooltip Visual Tests #DS-1314 #1542

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Test(web, web-twig, web-react, e2e): Tooltip Visual Tests #DS-1314 #1542

merged 4 commits into from
Jul 17, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

  • Enable and update visual test for tooltip

Additional context

  • The Placements demo has been moved to the bottom, above the advanced demo, so the demos at the top of the page are not in the "fold" of the screen.
  • Updated the script for the "Advanced demo" centering to be called after the resize event.

Issue reference

Visual tests for Tooltip

@pavelklibani pavelklibani self-assigned this Jul 11, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 46f9b55
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/669632bed5bfba000859144b
😎 Deploy Preview https://deploy-preview-1542--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 46f9b55
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/669632be456fee0008e63ea3
😎 Deploy Preview https://deploy-preview-1542--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 11, 2024 •
edited
Loading

Coverage Status

coverage: 77.951%. remained the same
when pulling 46f9b55 on test/ds-1314-visual-test-tooltip
into bd48607 on main.

@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9889662477/artifacts/1690415147

@pavelklibani pavelklibani removed the run-visual-tests Runs visual regression testing on this PR label Jul 11, 2024
@pavelklibani pavelklibani force-pushed the test/ds-1314-visual-test-tooltip branch 2 times, most recently from 127f1ef to 73170eb Compare July 11, 2024 10:45
@pavelklibani pavelklibani marked this pull request as ready for review July 11, 2024 10:59
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Jul 14, 2024
crishpeen
crishpeen approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the run-visual-tests label, I hope you don't mind. Otherwise LGTM!

packages/web/src/scss/components/Tooltip/index.html Outdated Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9927342573/artifacts/1699191305

@pavelklibani pavelklibani force-pushed the test/ds-1314-visual-test-tooltip branch from 73170eb to e13d924 Compare July 15, 2024 13:51
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9940683168/artifacts/1702030571

@pavelklibani pavelklibani force-pushed the test/ds-1314-visual-test-tooltip branch from e13d924 to 3ab6a52 Compare July 16, 2024 08:34
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9953487482/artifacts/1705349266

@pavelklibani pavelklibani force-pushed the test/ds-1314-visual-test-tooltip branch from a281972 to 46f9b55 Compare July 16, 2024 08:43
@pavelklibani pavelklibani merged commit 5e44a43 into main Jul 17, 2024
20 checks passed
@pavelklibani pavelklibani deleted the test/ds-1314-visual-test-tooltip branch July 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@crishpeen crishpeen crishpeen approved these changes

@curdaj curdaj curdaj approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@pavelklibani pavelklibani

Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelklibani @coveralls @literat @crishpeen @curdaj