Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce UNSTABLE_Avatar component #DS-1323 #1469

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Feat(web): Introduce UNSTABLE_Avatar component #DS-1323 #1469

merged 2 commits into from
Jun 21, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 7a2fa03
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6675876de7e23a000889b5e5
😎 Deploy Preview https://deploy-preview-1469--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 77.762%. remained the same
when pulling c5103f9 on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 77.762%. remained the same
when pulling c5103f9 on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

@coveralls
Copy link

Coverage Status

coverage: 77.762%. remained the same
when pulling bef04cf on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

@pavelklibani pavelklibani force-pushed the integration/web-unstable-avatar branch from bef04cf to 32dee04 Compare June 20, 2024 07:52
literat
literat approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@coveralls
Copy link

Coverage Status

coverage: 77.762%. remained the same
when pulling 32dee04 on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 77.762%. remained the same
when pulling 32dee04 on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

@pavelklibani pavelklibani force-pushed the integration/web-unstable-avatar branch from 32dee04 to 07a01cf Compare June 21, 2024 12:43
@coveralls
Copy link

Coverage Status

coverage: 77.762%. remained the same
when pulling 07a01cf on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

@coveralls
Copy link

Coverage Status

coverage: 77.834% (+0.07%) from 77.762%
when pulling dca5b50 on integration/web-unstable-avatar
into 8a6c985 on integration/unstable-avatar.

@pavelklibani pavelklibani force-pushed the integration/web-unstable-avatar branch from dca5b50 to e2f50a6 Compare June 21, 2024 13:17
@pavelklibani pavelklibani changed the base branch from integration/unstable-avatar to main June 21, 2024 13:17
@coveralls
Copy link

Coverage Status

coverage: 78.687%. remained the same
when pulling e2f50a6 on integration/web-unstable-avatar
into d35239a on main.

@pavelklibani pavelklibani force-pushed the integration/web-unstable-avatar branch from e2f50a6 to e978bae Compare June 21, 2024 13:45
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 7a2fa03
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6675876d92484c00087f84cb
😎 Deploy Preview https://deploy-preview-1469--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani force-pushed the integration/web-unstable-avatar branch from e978bae to 7a2fa03 Compare June 21, 2024 14:00
@coveralls
Copy link

Coverage Status

coverage: 77.957% (-0.7%) from 78.687%
when pulling 7a2fa03 on integration/web-unstable-avatar
into d35239a on main.

@pavelklibani pavelklibani merged commit d36d9fa into main Jun 21, 2024
17 checks passed
@pavelklibani pavelklibani deleted the integration/web-unstable-avatar branch June 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@curdaj curdaj curdaj approved these changes

Assignees

@crishpeen crishpeen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani @curdaj