Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC(web, web-twig) Refactor(web-react): Tooltip - Remove deprectations and changed internal classnames #1451

Merged
merged 6 commits into from
Jun 6, 2024
Merged

BC(web, web-twig) Refactor(web-react): Tooltip - Remove deprectations and changed internal classnames #1451

merged 6 commits into from
Jun 6, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented May 31, 2024 •
edited
Loading

Description

  • Removed deprecations from twig Tooltip
  • Demos in Web and Twig updated
  • Changed classnames to better correspond with our tooltip structure:
<.Tooltip spirit-data-element="tooltip">
  <.TooltipPopover>
    ...
  </.TooltipPopover>
</.Tooltip>

Additional context

  • I am open to suggestions for the README and MIGRATION files 🙏
    • README for web was updated a lot

Issue reference

Odstranit deprekace v komponentě Tooltip

@pavelklibani pavelklibani self-assigned this May 31, 2024
@github-actions github-actions bot added the BC Breaking change label May 31, 2024
@netlify Netlify
Copy link

netlify bot commented May 31, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ac3fe76
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66616771162f130008fa97f6
😎 Deploy Preview https://deploy-preview-1451--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani force-pushed the bc/ds-1267-tooltip-deprecation branch from f6b18a6 to fdca44e Compare June 3, 2024 07:08
@coveralls
Copy link

coveralls commented Jun 3, 2024 •
edited
Loading

Coverage Status

coverage: 78.535% (-18.4%) from 96.911%
when pulling ac3fe76 on bc/ds-1267-tooltip-deprecation
into c96fdf2 on integration/release-v2.

@pavelklibani pavelklibani marked this pull request as ready for review June 3, 2024 07:39
Base automatically changed from bc/ds-1249-tooltip-js-plugin to integration/release-v2 June 3, 2024 08:56
@pavelklibani pavelklibani force-pushed the bc/ds-1267-tooltip-deprecation branch from fdca44e to deea0a7 Compare June 3, 2024 12:15
crishpeen
crishpeen reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no migration guide needed for twig?

packages/web-twig/src/Resources/components/Tooltip/README.md Show resolved Hide resolved
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipTriggers.twig Outdated Show resolved Hide resolved
packages/web/src/js/__tests__/Tooltip.test.ts Outdated Show resolved Hide resolved
packages/web/src/scss/components/Tooltip/_TooltipPopover.scss Outdated Show resolved Hide resolved
@pavelklibani pavelklibani changed the title BC(web, web-twig) Refactor(web-react): Remove deprectations and changed internal classnames BC(web, web-twig) Refactor(web-react): Tooltip - Remove deprectations and changed internal classnames Jun 4, 2024
@pavelklibani
Copy link
Contributor Author

There is no migration guide needed for twig?

It is already added by you 😁

crishpeen
crishpeen approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

literat
literat approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Good Job :-)

@pavelklibani
BREAKING CHANGE(web-twig): Tooltip plugin support only TooltipFloatingUI
04482aa 
- fix and update demo to match demos in react and web
@pavelklibani
BREAKING CHANGE(web): Tooltip className changes #DS-1267
3af3d3c 
- Tooltip web package docs updated
- Tooltip web demo changed to reflect new classnames changes
@pavelklibani
BREAKING CHANGE(web-twig): Tooltip className changes
327d7d3 
- TooltipWrapper renamed to Tooltip
- Changed all stories to use the new Tooltip component structure
- Updated README
@pavelklibani
Refactor(web-react): Tooltip className changes #DS-1267
d4f1187 
- changed internal classnames for Tooltip
@pavelklibani
Test(web-react): Update test for tooltip
3fe6a48 
- updated to new structure using 'screen' function
@pavelklibani pavelklibani force-pushed the bc/ds-1267-tooltip-deprecation branch from 53f5240 to ac3fe76 Compare June 6, 2024 07:38
@pavelklibani pavelklibani merged commit 0d54664 into integration/release-v2 Jun 6, 2024
25 checks passed
@pavelklibani pavelklibani deleted the bc/ds-1267-tooltip-deprecation branch June 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@crishpeen crishpeen crishpeen approved these changes

@curdaj curdaj curdaj approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@pavelklibani pavelklibani

Labels
BC Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pavelklibani @coveralls @literat @adamkudrna @crishpeen @curdaj