Feat(web): Switch Select component to v3 design tokens #DS-1447

lmc-eu · Sep 17, 2024 · 9970915 · 9970915
1 parent e4c8059
commit 9970915
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 10 deletions.
diff --git a/packages/web/src/scss/components/Select/_Select.scss b/packages/web/src/scss/components/Select/_Select.scss
@@ -5,7 +5,6 @@
 @use '../../theme/form-fields' as form-fields-theme;
 @use '../../tools/form-fields' as form-fields-tools;
 @use '../../tools/reset';
-@use 'theme';
 
 $_field-name: 'Select';
 
@@ -39,7 +38,7 @@ $_field-name: 'Select';
     align-items: center;
     justify-content: center;
     aspect-ratio: 1;
-    color: theme.$icon-color-default;
+    color: form-fields-theme.$box-field-input-color-default;
     pointer-events: none;
 }
 
@@ -90,7 +89,7 @@ $_field-name: 'Select';
 }
 
 :is(.Select--disabled, .Select.is-disabled) .Select__icon {
-    color: theme.$icon-color-disabled;
+    color: form-fields-theme.$input-color-disabled;
 }
 
 :is(.Select--disabled, .Select.is-disabled) > :is(.Select__validationText, [data-spirit-element='validation_text']) {

diff --git a/packages/web/src/scss/components/Select/_theme.scss b/packages/web/src/scss/components/Select/_theme.scss
diff --git a/packages/web/src/scss/components/index.scss b/packages/web/src/scss/components/index.scss
@@ -25,8 +25,7 @@
 
 // @forward 'Radio';
 @forward 'ScrollView';
-
-// @forward 'Select';
+@forward 'Select';
 @forward 'Stack';
 @forward 'Tabs';
 @forward 'Tag';

diff --git a/tests/e2e/demo-components-compare.spec.ts b/tests/e2e/demo-components-compare.spec.ts
@@ -17,7 +17,6 @@ const IGNORED_TESTS: string[] = [
   'Link',
   'Pill',
   'Radio',
-  'Select',
   'Spinner',
   'Stack',
   'Text',

diff --git a/tests/e2e/demo-components-compare.spec.ts-snapshots/select-chromium-linux.png b/tests/e2e/demo-components-compare.spec.ts-snapshots/select-chromium-linux.png