fixup! BREAKING CHANGE(web-react): Switch Link, Heading and Text to v…

…3 design tokens #DS-1451
lmc-eu · Sep 17, 2024 · 31283eb · 31283eb
1 parent 24f2a35
commit 31283eb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/packages/web-react/src/types/heading.ts b/packages/web-react/src/types/heading.ts
@@ -2,6 +2,7 @@ import { ElementType, JSXElementConstructor } from 'react';
 import {
   ChildrenProps,
   EmphasisDictionaryType,
+  EmphasisProps,
   SizeExtendedDictionaryType,
   SizeProps,
   StyleProps,
@@ -23,9 +24,7 @@ export interface HeadingProps<T extends ElementType = 'div'>
     StyleProps,
     TransferProps {}
 
-export interface SpiritHeadingProps<T extends ElementType = 'div', S = void>
+export interface SpiritHeadingProps<T extends ElementType = 'div', S = void, E = void>
   extends HeadingProps<T>,
-    SizeProps<SizeExtendedDictionaryType<S>> {
-  /** Emphasis of the heading */
-  emphasis?: EmphasisDictionaryType | undefined | null;
-}
+    SizeProps<SizeExtendedDictionaryType<S>>,
+    EmphasisProps<EmphasisDictionaryType<E>> {}
diff --git a/packages/web-react/src/types/shared/dictionaries.ts b/packages/web-react/src/types/shared/dictionaries.ts
@@ -52,6 +52,10 @@ export type EmotionColorsDictionaryType<C = undefined> = (typeof EmotionColors)[
 export type EmphasisDictionaryKeys = keyof typeof Emphasis;
 export type EmphasisDictionaryType<C = undefined> = (typeof Emphasis)[EmphasisDictionaryKeys] | C;
 
+export interface EmphasisProps<E> {
+  emphasis?: E;
+}
+
 export type TextColorsDictionaryKeys = keyof typeof TextColors;
 export type TextColorsDictionaryType<C = undefined> = (typeof TextColors)[TextColorsDictionaryKeys] | C;
 

diff --git a/packages/web-react/src/types/text.ts b/packages/web-react/src/types/text.ts
@@ -2,6 +2,7 @@ import { ElementType, JSXElementConstructor } from 'react';
 import {
   ChildrenProps,
   EmphasisDictionaryType,
+  EmphasisProps,
   SizeExtendedDictionaryType,
   SizeProps,
   StyleProps,
@@ -23,9 +24,7 @@ export interface TextProps<T extends ElementType = 'p'>
     StyleProps,
     TransferProps {}
 
-export interface SpiritTextProps<T extends ElementType = 'p', S = void>
+export interface SpiritTextProps<T extends ElementType = 'p', S = void, E = void>
   extends TextProps<T>,
-    SizeProps<SizeExtendedDictionaryType<S>> {
-  /** Emphasis of the text */
-  emphasis?: EmphasisDictionaryType | undefined | null;
-}
+    SizeProps<SizeExtendedDictionaryType<S>>,
+    EmphasisProps<EmphasisDictionaryType<E>> {}