Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lowering of torch.aten.triu_indices #3451

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Implement lowering of torch.aten.triu_indices #3451

merged 3 commits into from
Jun 21, 2024

Conversation

BaneTrifa
Copy link
Contributor

@ramiro050 ramiro050 self-requested a review June 14, 2024 19:04
ramiro050
ramiro050 requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Some initial, mostly stylistic comments. Have yet to think about the algorithm used

lib/Dialect/Torch/IR/TorchOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/abstract_interp_lib_gen.py Show resolved Hide resolved
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
@BaneTrifa BaneTrifa requested a review from ramiro050 June 15, 2024 12:31
@BaneTrifa BaneTrifa requested a review from ramiro050 June 18, 2024 13:42
ramiro050
ramiro050 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramiro050 ramiro050 merged commit 98c6971 into llvm:main Jun 21, 2024
3 checks passed
@vivekkhandelwal1 vivekkhandelwal1 mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro050 ramiro050 ramiro050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torch.aten.triu_indices
2 participants
@BaneTrifa @ramiro050