Add new builder configuration to test use of LLVM dylib across all tools #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternate approach to #37, I think there's value in testing both config. |
|
What's being tested with the compiler-rt build? |
|
On Wed, Jul 12, 2023 at 01:27:28PM +0000, Tom Stellard wrote:
What's being tested with the compiler-rt build?
I can't tell exactly, but compiler-rt/test contains a lot of reference to %llvm*
and %clang* that are going to use libLLVM.
|
|
@serge-sans-paille What's the advantage of having two separate builders? |
|
The patch itself looks fine. |
tstellar
reviewed
Sep 30, 2023
| "-DCOMPILER_RT_INCLUDE_TESTS:BOOL=OFF", | ||
| "-DCOMPILER_RT_BUILD_LIBFUZZER:BOOL=OFF", | ||
| "-DCMAKE_C_FLAGS=-Wdocumentation -Wno-documentation-deprecated-sync", | ||
| "-DCMAKE_CXX_FLAGS=-std=c++11 -Wdocumentation -Wno-documentation-deprecated-sync", |
There was a problem hiding this comment.
I don't think this will work to add the -stdc=c++11 flag here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.