Update LLVM WoA buildbots for better coverage #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates LLVM WoA bots with following changes: 1) Do not run stage1 testing on 2 stage clang bot. 2) Remove redundant workers. 3) Remove -DCOMPILER_RT_BUILD_PROFILE=OFF 4) Add compiler-rt to single stage bot 5) Set clean=False for the 2stage bots 6) Set "-DCLANG_DEFAULT_LINKER=lld" for all WoA bots
DavidSpickett
changed the title
|
Sorry I completely missed this.
Does this make a difference now that we use ccache? Also we may have to switch it back to clean if #266 works out. You can leave it in here for now though. |
DavidSpickett
added a commit
to llvm/llvm-project
that referenced
this pull request
Oct 23, 2024
…n Arm This test has been failing since https://lab.llvm.org/buildbot/#/builders/161/builds/2899, but no change in that build caused it. I think this has always failed but llvm/llvm-zorg#252 only recently enabled in on the bot.
omjavaid
added a commit
to omjavaid/llvm-zorg
that referenced
this pull request
Oct 24, 2024
Since llvm#252 we have got increased build times on WoA build bots. Also WoA 2 stage bot does not collapse the queue because it is not configured to always do a clean build. This patch tries to fix above issues. On both single and 2 stage bots: - Set `LLVM_TARGETS_TO_BUILD` to 'ARM;AArch64;X86'. We only care about these targets on windows. On 2 stage bot: - Set stage 1 LLVM_TARGETS_TO_BUILD to AArch64 only. - Set extra_stage2_cmake_args which overrides extra_cmake_flags. - Disable flang build on stage1 by setting checkout_flang=False. - Enabled `LLVM_ENABLE_PROJECTS=flang;mlir` for stage 2. - Switched to a clean build (`clean=True`) for collapsing queue. - Like stage 1 set stage 2 CLANG_DEFAULT_LINKER to lld. This makes sure just built lld is used by just built clang as default linker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates LLVM WoA bots with following changes: